Andrew Hodel

Failed to open

12

Whenever I use these libraries CAN_BUS_Shield NMEA2000 NMEA2000_mcp and any of the examples in NMEA2000 I get "failed to open CAN device". However, if I use just the MCP2515 library...

3d chart doesn't work with extendTraces() if all traces are set to 0 points first

1

It does work if the points are not removed from the existing traces though. https://jsfiddle.net/v4mghLd5/1/

parseString callback doesn't always return an object

2

Shouldn't the 2nd argument to cb() always return an object? https://github.com/Leonidas-from-XIV/node-xml2js/blob/master/lib/parser.js#L303 It's a problem if you check for errors by validating a one layer deep field in the 2nd argument...

I sent a 20 byte value as Sec-WebSocket-Key and everything works fine, but the RFC states that the value must be exactly 16 bytes when decoded from base64! That's a...

settings.json with human readable list of options that are required per version

1

Or get rid of the slice parameter, without the settings.json (perhaps remove the -s parameter). Or output that every parameter is required with a list of those parameters in the...

Examples don't close the connection properly if executed in a loop.

1

Linux 4.14.209-160.339.amzn2.x86_64 If ran in a loop, basically the Get example with a new connection being created each time. It doesn't make sense to use defer as there are no...

This will show: ``` --------------New Gcode Loaded-------------- Min Dimensions X: 0 Y: 0 Z: -14 Max Dimensions X: 20.79129557 Y: 20.79129557 Z: -4 Total Dimensions X: 20.79129557 Y: 20.79129557 Z:...

sync speed on small files, give me the code location of the initiating loop and I'll make it faster

11

It is quite obvious that it gathers a list of the src and dest, then creates a diff, then one by one copies each file. Between each finish and start...

I don't know why github requires a fork to make a pull request, but here's a repo with everything working if you want to incorporate. https://github.com/andrewhodel/node-named

password length limit

7

Why make the limit very small, 100 characters? I realize it needs to be allocated and that the password is stored as a salted hash that is much shorter than...