Andreu Botella

Results 99 comments of Andreu Botella

It's true that most WPT tests that we run, even the `*.window.js` ones, don't depend on the presence of `window`, but there are some that do. For example, the webstorage...

`window` is already removable by doing `delete globalThis.window`.

> This will likely have to wait until `@font-face` are stored in the per-layout data structures: #32033. Maybe `unicode-range` can be stored in the per-layout structure, but about other `@font-face`...

The `is_disturbed` field of `ReadableStream` isn't used. It should be set to true on `read_a_chunk` and checked in the `is_disturbed` method.

If I'm understanding this change correctly, this will make any program using deno_core without snapshots non-distributable. Regardless of whether we want even small users of deno_core to rely on snapshots,...

> > If I'm understanding this change correctly, this will make any program using deno_core without snapshots non-distributable. Regardless of whether we want even small users of deno_core to rely...

Since Infra specifies that user agents can have implementation-defined limits, I think the way to specify this would be to have this user-set limit as an extra limit on top...

The tests in `built-ins/AsyncContext/context-propagation/*` are really tests that the changes to the `HostMakeJobCallback` and `HostCallJobCallback` host hooks are indeed reflected in the built-in APIs that use those hooks. Maybe they...

> I really don't understand why it matters since from what I understand no spec steps iterate or otherwise return the keys. It effectively is a WeakMap and the implementation...

> I agree with WeakMap. The following example would be a memory leak, no? > > ```js > function a(request){ > const aVar = new Variable(); > > aVar.run(request.url, ()...