Andreu Botella
Andreu Botella
This PR got stuck for a while while most of the realm code got reverted because it was blocking performance work. All of the PRs that were preconditions for modules...
PTAL @bartlomieju @littledivy. Although this is probably not ready for merging, and the comments https://github.com/denoland/deno/pull/15760#issuecomment-1279953186 and https://github.com/denoland/deno/pull/15760#issuecomment-1281613105 are still things to fix, it would be good to get some initial...
> The question about `ModuleLoader` is an interesting one and I don't have a good answer right now. Does spec say anything about it? The HTML spec requires a level...
Since `JsRuntime::create_realm` can be used to create "regular" (non-shadow) realms, for example if we ever support the Node.js `vm` module, I thought it was better to require the realm creator...
I think this PR is now ready for review. The commit message contains a somewhat detailed list of changes. I thought changing the module map to be stored on a...
> Could you remind me of the reason why we need `global_realm` to be an `Option`? If we removed the `Option` we could get rid of a lot of clones....
> Appears that's currently not possible, because `v8::Global` APIs still require a valid `Isolate` handle. I'll think about it more. I think I'd be fine with initializing `global_realm` to `MaybeUninit::zeroed().assume_init()`....
> > Appears that's currently not possible, because `v8::Global` APIs still require a valid `Isolate` handle. I'll think about it more. > > I think I'd be fine with initializing...
This has now landed on the deno_core repo. Closing.
In my (WIP) blog I'm using `"git created"` by default, and overriding that when needed with ISO timestamps, so I don't run into this issue when parsing dates. But yeah,...