Andreas Gerstmayr
Andreas Gerstmayr
> I wonder a bit about the jq dependency - should we vendor this and drop our own pmjson (or install 'jq' as 'pmjson' for back-compat, since that's released and...
I think an easy solution for this problem would be if all links to fava extension pages have the `data-remote` attribute, which prevents fava from intercepting the link: https://github.com/beancount/fava/blob/212c86adb2c6f268845384737efd446b743e5342/frontend/src/router.ts#L187-L207 This...
> @andreasgerstmayr You've requested a review from me but you haven't yet addressed @jrasm91 comments and there are also lots of merge conflicts right now...? hi @danieldietzler, sorry about that,...
Sounds great!
> suggest adding trim or detailed description for the api. @bjosv I'd vote for adding it to the docs instead of adding `sdstrim` to all connect functions. imho it's reasonable...
This is a first draft to replace OpenTracing with OpenTelemetry SDK. Some open questions * is creating a tracer per package best practice? https://github.com/open-telemetry/opentelemetry-go/discussions/4532 * OTEL only supports [Int64 attributes](https://pkg.go.dev/go.opentelemetry.io/[email protected]/attribute#Int64)...
> One concern I have is whether we lose the server spans. I see the dskit change linked above, but I'm not clear this addresses the issue. Currently, many spans...
I tested it in microservices mode today, looks good so far. Please let me know if you find any broken traces.
Reading https://redis.io/commands/pubsub you can send `PUBLISH`/`SUBSCRIBE` to any node in the cluster. You can use `redisClusterAsyncCommandToNode()` to send a command directly to a specific node. Should hiredis-cluster send the command...
To be honest I never tested it with a stock merge (never occurred in my private ledger so far), only with stock splits. Does [beangrow](https://github.com/beancount/beangrow) handle this properly?