immich icon indicating copy to clipboard operation
immich copied to clipboard

Published 20 hours ago • verified publisher icon immich-app

feat(server, web): include pictures of shared albums on map

Open andreasgerstmayr opened this issue 1 year ago • 4 comments

This PR adds a new setting "Include shared albums" to the map settings, to includes pictures of albums shared with the current user on the map.

Related: #3176

andreasgerstmayr avatar Feb 26 '24 22:02 andreasgerstmayr

@andreasgerstmayr You've requested a review from me but you haven't yet addressed @jrasm91 comments and there are also lots of merge conflicts right now...?

danieldietzler avatar May 02 '24 09:05 danieldietzler

@andreasgerstmayr You've requested a review from me but you haven't yet addressed @jrasm91 comments and there are also lots of merge conflicts right now...?

hi @danieldietzler, sorry about that, must have been some automated process (it's showing up as 2:35 in the night), maybe because you're listed as a codeowner. No idea why it's happening now and not when I created the PR though.

Sorry for the late response, I was on holiday for a couple of weeks and then didn't get time so far. Thanks for the review, I'll rebase and implement the changes soon.

andreasgerstmayr avatar May 02 '24 11:05 andreasgerstmayr

Ah ok got it. No rush then :)

danieldietzler avatar May 02 '24 12:05 danieldietzler

I fixed the merge conflicts and implemented (most of) @jrasm91 suggestions now (except the one I didn't understand, see above). Sorry for the delay on my side!

andreasgerstmayr avatar May 09 '24 21:05 andreasgerstmayr

I fixed a tsc error caused by changes in main since the branch was created as well as a prettier error in web. The PR should now be good to merge

zackpollard avatar May 13 '24 10:05 zackpollard

I updated this to include assets that are in shared albums where the user is the owner.

Good catch! I didn't think of that.

Thank you for merging! :)

andreasgerstmayr avatar May 14 '24 20:05 andreasgerstmayr