Albert Mink

Results 34 comments of Albert Mink

Feature is implemented behind the experimental flag see Example repository with new file format in https://github.com/albertmink/testing_intf_aff Note: Metadata (documentation in class-builder) might get lost while serializing, see #5373

#5163 requires SAP Note * 3138721 - Remove Feature Toggle for ABAP File Formats * 3145107 - Write posix EOF and EOL (for JSON) * 3138884 - Update CHKO, CHKC...

- [x] Do UT with JSON metadata ``` { "formatVersion": "1", "header": { "description": "Example interface for ABAP file formats", "originalLanguage": "en" } } ```

Note: UT are green, however the expected values have to be double checked

> wouldnt it be easier for the user just to install the dev version? and easier to maintain Yes and but what if in the ABAP system there is a...

I am bad in comparing numbers, but the tags shown in git and AG look good. Here, the tags in the git repository

Let me share my experience with the topic. When I committed the object handler ``` src/objects/aff/zcl_abapgit_object_chkc.clas.abap src/objects/aff/zcl_abapgit_object_chko.clas.abap src/objects/aff/zcl_abapgit_object_chkv.clas.abap ``` I stumbled across the TADIR when de-/serializing, see fixes in a18d7542...

Hope it is ok for you, to reference this one #207 here in the general ENHO issue 😃

@Bomberus are you ready to merge? I can overrule the pending checks manually. They are meaningless, since the checks got renamed/restructured in #574. The green ones are the important ones...