Akin

Results 421 comments of Akin

@bryphe sure will add a simple test to this PR. Re. vscode-textmate and the use of process they use it to have access to env variables for debugging as well...

@justinmk it definitely sources a way to show the prompt which we can GUI-fy :+1:. One thought I've had is that with that something like a confirm quit dialog you'd...

@FredrikAleksander any luck successfully getting the `rls` to run without issue or is the above still happening?

@appelgriebsch thanks for checking this with another client. I'm quite keen to get this working as well, I think our lsp client has some issues as it reports some errors...

@MikaAK thanks for pointing this out I thought there was maybe a solution for this. I don't think we would ship oni with one for elixir but would be good...

@badosu it is expected that it should return results as [markdown](https://microsoft.github.io/language-server-protocol/specification#textDocument_completion) and we actual used `marked` to render the markdown that comes into the hover tooltip, I made a PR...

Think this is actually a good first issue since all the pieces are in place and we can just replicate what we did for the hover tooltip if anyone wants...

@Hindol that would be amazing thanks 👍 re. how to implement this I suggest initially having a look at the [Hover Renderer](https://github.com/onivim/oni/blob/e612eb860224d9f36528501cfd7c3a221e635305/browser/src/Editor/NeovimEditor/HoverRenderer.tsx#L177) we use a function called `convertMarkdown` from `markdown.ts`...

Actually reading about this online it seems to be a bit of a debate but I *think*/most of my mac apps fully close when I hit `cmd-q`, save the snippet's...

@amireldor there was an explicit change in #1454 here https://github.com/onivim/oni/pull/1454/files for reasons that @bryphe explained in there I also find it frustrating tbh but can try changing the quick info...