oni icon indicating copy to clipboard operation
oni copied to clipboard

Jump-to-definition not functional before symbol tooltip is shown

Open amireldor opened this issue 7 years ago • 2 comments

Oni Version: 0.3.6

Neovim Version (Linux only): NVIM v0.3.0-1250-ge121b1dbe

Operating System: Ubuntu, or at least what's left of it after I did funny things (to the UI, so my issue is probably not related to OS).

Issue:

When jumping to definition, be it with gd or F12, you have to wait for the little definition tooltip to pop up before the goto-definition action is functional. So if you move the cursor to a symbol and hit gd it won't necessarily work if you're too quick. This is not fun.

Related code might be here after a conversation with Ryan C on discord: https://github.com/onivim/oni/blob/4ce6b2289afa6018800521617bcaeb0eb9b8df39/browser/src/Editor/NeovimEditor/Definition.ts#L23

Expected behavior:

Not having to wait for the little tooltip to be shown before jump to definition is functional. And yes, "wait" is barely ~120ms but it's still some kind of wait.

Actual behavior:

Before the tooltip is shown, gd or F12 do nothing. After tooltip is shown, they function as they should.

Steps to reproduce:

Just be quick.

But seriously, I work with easymotion so I if I jump to a symbol with 2-3 letters then the gd are just two more letters that are pressed almost instantly. This is how I experience this issue mostly.

I think that keeping track a "hovered symbol" might be a solution, and maybe it should be debounced with something like ~10ms to not choke Oni.

amireldor avatar Aug 30 '18 23:08 amireldor

@amireldor there was an explicit change in #1454 here https://github.com/onivim/oni/pull/1454/files for reasons that @bryphe explained in there I also find it frustrating tbh but can try changing the quick info delay and seeing if that helps

akinsho avatar Aug 31 '18 12:08 akinsho

@Akin909 @amireldor Anyway disable the tootip?

symphony2014 avatar Feb 27 '19 22:02 symphony2014