Aaron Fisher

Results 39 comments of Aaron Fisher

@jamiebramwell Do you think the: bool IsXInY() methods have a use for your team? Any other mesh id number info that you think would be useful here?

@pazner Are the dimension independent methods that I added about what you had in mind (at least for the interface)?

One thing that @samuelpmishLLNL brought up is the possibility of GPU execution of these. While I don't want to handle that in this PR I'll want to make sure we...

> I like the entity approach (obviously). The function names don't make sense though. > > `ChildrenInEntity`, there is no children in an entity. There can be children of an...

@rcarson3 Have a look at the doxygen I added. Please let me know if anything is unclear of if there is an unaddressed need for mesh connections.

All, there is one thing I want to bring up for discussion. I currently have plural and singular calls like ChildrenOfEntity, and ChildrenOfEntities. It would be possible to fold all...

> I'd vote for plural only. Also, `MeshEntityIDs` should really be a namespace object s.t. `Mesh::EntityID` is valid. > > I'm not convinced on the need of `EntityIDs`. `std::vector` (or...

> > I'm not convinced on the need of `EntityIDs`. `std::vector` (or `mfem::Array` if it really has to) seems more natural to me. > > IMHO an `EntityID` is unique....

Alright, I think the interface has settled to the point that I can start writing tests to it. Hopefully any further changes will be minor. Thank you all for your...

I haven't forgotten this WIP. I just pushed up some more touches on the MeshConnections interface, and also my first swipe at the changes to the Mesh interface. One thing...