Aaron Prindle

@ericzzzzzzz the idea here is to verify that all of the necessary Events v2 API changes were made in the skaffold `v2` binary (@ HEAD). In the case of any...

Awesome! We can assign this issue to you then @OladapoAjala. Seems I am not able to assign this using the Github UI currently though, perhaps when your other PR is...

Great, I've assigned this now. For more context here, currently skaffold apply supports the --enable-rpc flag which is deprecated but not the newer --rpc-port flag: https://github.com/GoogleContainerTools/skaffold/blob/main/cmd/skaffold/app/cmd/flags.go#L210-L217 Name: "rpc-port", ... DefinedOn:...

@CuriousCorrelation

In attempting the manual testing steps above I am seeing: ``` Build [go-guestbook-frontend] failed: creating bucket if not exists: getting bucket "k8s-skaffold_cloudbuild": Get "https://storage.googleapis.com/storage/v1/b/k8s-skaffold_cloudbuild?alt=json&prettyPrint=false&projection=full": metadata: GCE metadata "instance/service-accounts/default/token?scopes=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdevstorage.full_control%2Chttps%3A%2F%2Fwww.googleapis.com%2Fauth%2Fcloud-platform" not defined...

Talked offline w/ @renzodavid9 who was able to get this working with the steps above. I believe this is some error with my gcloud or pantheon configuration.

Yes you are correct, currently `skaffold generate-pipeline` is not implemented for V2. I think this is lower priority compared to the other tests so now regarding: > Implementing that seems...

This is confirmed from @MarlonGamez to be low priority. Removing from the current milestone

+1 the likely solution here will be to support `hooks` in the `manifests` section (render phase). This wasn't considered initially but it makes sense that `hooks` will likely be desirable...

Nice, this change definitely makes sense. it seems that this is failing a lint check that we have: ./ftl/node/layer_builder.py:54:80: E501 line too long (89 > 79 characters) If you can...