Rosario

Memory leak

2

If the allocation on line fast_obj.h#1450 fails the memory allocated at fast_obj.h#1397 is leaked. https://github.com/thisistherk/fast_obj/blob/85778da5fc320b7e52885f8e869edc079695cc79/fast_obj.h#L1450

I tried to run the latest version of the sample and I encounter an error during the loading. The problem is that some of these shaders here https://github.com/NVIDIAGameWorks/RTXDI/blob/52488baa0dd3ee0dffb6e668bd0695d65cd2345c/src/LightingPasses.cpp#L313C91-L320C91 are missing...

The files `ffx_fsr2_force16_begin.h` and `ffx_fsr2_force16_end.h` are not included in the repository. https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/149cf26e1229eaf5fecfb4428e71666cf4aee374/src/ffx-fsr2-api/shaders/ffx_fsr2_upsample.h#L88 https://github.com/GPUOpen-Effects/FidelityFX-FSR2/blob/149cf26e1229eaf5fecfb4428e71666cf4aee374/src/ffx-fsr2-api/shaders/ffx_fsr2_upsample.h#L96

If neither FFX_GLSL or FFX_HLSL is defined SpdReduceQuad fail silently. This is can lead to really hard to debug issue if you try to add supports for another compiler. https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/include/FidelityFX/gpu/spd/ffx_spd.h#L602

Optical flow scheduleDispatch unused parameter.

1

Hello, pipelineName in scheduleDispatch is not used. https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/src/components/opticalflow/ffx_opticalflow.cpp#L465 The worst part is that it's a std::string so it allocates memory at runtime even when passing a static name. I haven't...

Macro doesn't expand correctly in CLANG / GCC

1

The macro `#define EAN(pass) pass, L#pass` found here https://github.com/GPUOpen-LibrariesAndSDKs/FidelityFX-SDK/blob/a0632abf1350bb64c098573d84c42f053f053a6e/sdk/src/components/opticalflow/ffx_opticalflow.cpp#L220 doesn't expand correctly in CLANG or GCC. Can we please change it to `#define EAN(pass) pass, L###pass`? This should work on...