Vasyl Marchuk comments

Results 12 comments of


                                            Vasyl Marchuk

Element modifiers don't work with multiple lines

I also tried ``` div.some-class [ (did-insert this.onInsert) ] ``` but that didn't work either

Element modifiers don't work with components

Found a very likely related issue: https://github.com/emberjs/ember-render-modifiers/issues/15

Colon syntax does not work if nesting component into component

So, I figured out the syntax that works, but it has ambiguity in it * ` = my-component: my-other-component` - renders `MyOtherComponent` inside `MyComponent` * `= my-component: accordion` - renders...

A permanently fixed Asteroid Hatch explodes after undocking or time-warping

I believe I found a workaround/reason: **dock something else** to an asteroid **before** _attaching_ the hatch (attaching, not fixing permanently). If you already attached the hatch, dock another vessel to...

Fix flaky test with code examples list

It fails for me on localhost too, as well as 3-4 others (which count API requests). Would be great to fix!

Use CodeMirror for rendering code/diffs

@rohitpaulk Broke up all the steps into several simple task-lists above. I have a lot of unfinished/experimental changes for many of those steps, already splitting them into half a dozen...

Investigate extra `await settled` and `await animationsSettled` calls in tests

It appears that if we properly use https://www.npmjs.com/package/@ember/test-waiters in our components, this problem will be fixed, or at least will become much more manageable.

Use CodeMirror on Admin Submissions Diff tab

@rohitpaulk Just fixing the remaining broken tests right now and will request review once done!

Use CodeMirror on Admin Submissions Diff tab

@coderabbitai full review @coderabbitai summary

Upgrade embroider, use vite

https://github.com/mainmatter/ember-vite-codemod