Ted Driggs

Results 156 comments of Ted Driggs

I'm looking at this now; is `String` the best type to model this in Rust? I was thinking a tuple struct with two fields (one before the period, one after),...

A PR with a documentation update and/or an entry in examples would be welcome.

The issue appears to be coming from [these lines](https://github.com/colin-kiegel/rust-derive-builder/blob/master/derive_builder_core/src/setter.rs#L183-L195). It looks like this initialization code will need to take the field type into account. I'm happy to review a PR...

I expect right now we’d be blocked on TedDriggs/darling#238, given that this crate uses `pub` to mark field and setter visibility. It doesn’t look like `syn` will revisit its behavior...

I took another look at this, and hit a couple specific issues: - [x] After updating to darling 0.20.4, the "unknown field" errors all say "unresolved import" instead of the...

https://github.com/colin-kiegel/rust-derive-builder/tree/darling-0.20.4 We have to rename `type` because `syn` decided to stop allowing keywords as meta-item identifiers. The two leading candidates for the rename would be `ty` or `r#type`; of those,...

Okay, I figured out the issue with the diagnostic messages by bumping all the crates to the 2018 edition. Now things seem to be on a better path; I think...

Okay, it looks like all the tests on the branch linked above are passing again, so as long as all the various no_std and no_alloc test crates are properly running...

I've created #306 as an option for giving people a source-compatible migration path. That updates the `syn` 1 version of the crate to accept `field(ty = "...")` _or_ `field(type =...

@jtran PR for this is now up, if you can give it a look that would be much appreciated.