Ted Driggs
Ted Driggs
You can compare errors from this branch to the ones in main: https://github.com/djc/askama/pull/537; try changing `ext` to `ex` in a test to see the difference.
@Peternator7 I'm the maintainer of `derive-builder`, and we just went through this issue with our 0.10.0 release. What we ended up with that worked well was: ``` // exported by...
* The `expect` call should unwrap the build result with a nicer panic message. In this case, there was no `RequestEnvelopeBuilder`, but there was a hand-rolled `From` impl. * See...
`TryFrom` is now supported below this crate's MSRV, so this should be ready to implement.
It is not actively being looked at. * We wouldn't support `From` given that building is typically fallible. * Supporting `TryFrom` is possible, but may be fiddly due to all...
My understanding is that generating unnecessary trait implementations can increase code size. Given that `derive_builder` is widely-used, there isn't a widespread need for these to `impl Eq`, and that there...
Have you tried using `#[builder(derive(PartialEq))]`? That should allow you to derive it and `Eq`
The recommended fix would be to manually implement the error for this builder. ________________________________ From: Evan Carroll ***@***.***> Sent: Sunday, June 12, 2022 8:40:31 PM To: colin-kiegel/rust-derive-builder ***@***.***> Cc: Ted...
In that situation, the recommended solution would be to use your own error struct. ```rust pub enum SequenceError { BuilderMissingField(&'static str), } impl From for SequenceError { fn from(err: derive_builder::UninitializedFieldError)...
The use-case makes sense to me. However, this is the first time I've heard of it being needed, so I'm not sure how widespread the need is. In approach 2,...