Jordan

Results 11 comments of Jordan

@Rodeoclash this function has served me pretty well so far - will need some refactoring to work with this codebase, but hopefully is helpful: ``` function makeFriendlyNumber(value, fixedDecimals, prefix, formatFunction)...

@a8m what are your thoughts on this? should strings be allowed? I don't see any reason to limit this other than, perhaps, consistency? happy to contribute! p.s. I like that...

if you want to allow strings, my proposed function would be: ``` function(value, decimals) { if(!value) { return 'NaN'; } if(!decimals) { decimals = 0; } value = parseFloat(value); if...

yes.. that makes more sense so something like... ``` function tryConvertToNumber(input) { // this is not a trash bin if (!input) { return input; } if (isString(input)) { var num...

I am finding a hard time finding a downside to supporting strings here. I understand where you're coming from theoretically speaking and completely respect that. Considering, however, that this is...

Will do - will try to get that change in today, but next two days are very busy so might not be until Wednesday

@a8m do you want me to extend this tryConvertToNumber to all filter methods under _filter/math? Slightly revised function below: ``` function tryConvertToNumber(input) { // this is not a trash bin...

fell a bit behind on this ... end of sprint / deployment week ... going to try to get this done now

I like that approach, but do we want to support all object types Number() accepts? If someone accidentally uses a Date object they could end up with some unexpected results.....