Robert Winkler comments

Results 597 comments of


                                            Robert Winkler

Cannot run init

Hi, would you like to provide a PR. I won't have time to update it.

Each task always starting at rootProject of current project

Hello, yes, feel free to create a PR when it's working as expected. Thanks :+1:

Remote branch not deleted when finish release

Hi, do you mean the release branch? It should not be pushed to a remote. Strange. I have a look at it. Btw. If you use the plugin, I would...

Remote branch not deleted when finish release

I'm a bit busy with work and the other OS projects Swagger2Markup and Javaslang. Do you think you can create a Push Request?

Question about deleting/removing a RateLimiter instance

Hi, sry for the late response. 1.) The implementation is described here: https://resilience4j.readme.io/docs/ratelimiter#internals We don't spawn any threads in the background. Your understanding is correct. 2.) I would recommend to...

Question about deleting/removing a RateLimiter instance

Hi, actually I don't remember why it wasn't implemented. @storozhukBM has implemented the RateLimiter

Circuitbreaker fallback is triggered even when the circuit is closed

The fallback mechanism works similar to a try/catch. You have to narrow down the scope of your exception handler to `CallNotPermittedException`, if you only want to handle the case when...

Circuitbreaker fallback is triggered even when the circuit is closed

Retry is rethrowing the original exception. It is only throwing a `MaxRetriesExceededException`, if the remote service returns a result which signals an error and retry attempts exceeded. Because in that...

Circuitbreaker fallback is triggered even when the circuit is closed

Did you try to debug it?

Retry bugdet implementation

Hi, interesting idea. Indeed, a retry bugdet solves a different issue than a circuit breaker. Feel free to prepare a PR.