Robert Winkler comments

Results 597 comments of


                                            Robert Winkler

RateLimiter: check current state of key?

Hi, sry I don't get the question. The state of an instance of a rate limiter?

[Enhancement request] Support for Prometheus tags

Hi, no there are no plans right now. But feel free to create a PR. We need any support.

Resilience4j-rxjava2 is needed when using reactor

Hi, @pollend it seems that `RateLimiterInterceptor` has a compile dependency to RxJava2. Is that required? We should make it pluggable like in Spring Boot, if possible. @LenaKucharczuk From my point...

Multiple instances of Abstract classes having public constructors

Hi, thanks. Feel free to create a PR

Using WebClient with Mono.zip stuck in half-open state.

I assume Mono.zip does not cancel the other requests, if one request fails? :( Did you try to debug it?

Use fallback when CallNotPermittedException

Hi, do you use Spring Boot and Annotations?

Use fallback when CallNotPermittedException

Then define a fallback method which catches `CallNotPermittedException`.

Use fallback when CallNotPermittedException

Did you have a look at this? https://resilience4j.readme.io/docs/getting-started-3#fallback-methods

Use fallback when CallNotPermittedException

You could narrow down the scope of the exception. In that case the fallback is only called when a `CallNotPermittedException` occurs. ``` fun fallbackCommentsAccess( articleId: String, reason: CallNotPermittedException ): CompletableFuture?...

Add the ability to update an existing RateLimiter in RateLimiterRegistry

Hello, the following code changes the current instance. There is no need to replace this RateLimiter instance in the RateLmiterRegistry after chaning the values. Or do you want to get...