Nicholas Thomson
Nicholas Thomson
> Could this also be the case for `AdoptedResource` too? Absolutely! I think we have some very minimal condition handling in `AdoptedResource`, but that definitely needs some more love and...
> @RedbackThomson Should we duplicate this issue for `AdoptedResource` or use this one as a catchall? I will duplicate so we can track them separately
/remove-lifecycle stale
/lifecycle frozen
/lifecycle frozen
> I tried looing into the code myself, but felt a bit lost. Particularly understandable for the `rds-controller`, which is quite a complex beast of custom code.
/lifecycle frozen
/lifecycle frozen
The `Versioningc` is just a typo in the error message code - https://github.com/aws-controllers-k8s/s3-controller/blob/e0addd656d76730fbf0eac428e29f4520b0525ba/pkg/resource/bucket/hook.go#L279 This error message only happens when the code attempts to update versioning or replication settings for the...
Weirdly I don't see a required annotation on the region field in the Go code: https://github.com/aws-controllers-k8s/runtime/blob/main/apis/core/v1alpha1/resource_metadata.go#L33-L34 But I do see it set to required in the CRD: https://github.com/aws-controllers-k8s/elasticache-controller/blob/main/config/crd/bases/elasticache.services.k8s.aws_replicationgroups.yaml#L431-L433 It's possible...