community icon indicating copy to clipboard operation
community copied to clipboard

Published 20 hours ago • verified publisher icon aws-controllers-k8s

Adopted resource reconciler does not check for incorrect identifier

Open RedbackThomson opened this issue 4 years ago • 5 comments

Describe the bug When creating an adopted resource that should require a nameOrID, if you provide it with an ARN, the reconciler will not throw an error that you have mismatched the identifier type. This also works with providing a nameOrID when expecting an ARN.

Steps to reproduce

  1. Create a resource that requires a nameOrID field to adopt
  2. Attempt to adopt the resource by setting spec.aws.arn to any value
  3. See the error is related to the describe call, or the adoption even succeeds (some ReadMany calls allow for an empty identifier)

Expected outcome The adoption reconciler should place the adopted resource into a terminal condition with an appropriate error message about the incorrect identifier.

RedbackThomson avatar Aug 31 '21 19:08 RedbackThomson

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Nov 29 '21 23:11 ack-bot

/remove-lifecycle stale

RedbackThomson avatar Nov 30 '21 19:11 RedbackThomson

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Feb 28 '22 23:02 ack-bot

/lifecycle frozen

a-hilaly avatar Mar 01 '22 14:03 a-hilaly