Andrey Savchenko

> Here's my phpunit 8 output Hm, which PHP CS version? Are you installing according to lock file or updating to latest?

Scrutinizer is currently failing on the constant thing too (tad different message, it's higher severity in PHP 8 locally). Not sure what's up with it, but PHP CS seems to...

Ok, that exchanged for a new error in Scrutinizer: > PHP_CodeSniffer\Exceptions\DeepExitException: ERROR: option "--coverage-clover=clover.xml" not known Given that is a parameter being used _for PHPUnit_, PHP CS shouldn't even be...

It looks to me like PHP CS code yanks arguments from command line and gets confused what those are (since command line is for PHPUnit actually). I am not familiar...

Ugh, busy year... War and stuff. :) So, I ditched Scrutinizer and moved tests setup to GitHub actions and more careful PHP 7.2 + PHPUnit 8 set up (for minimal...

> `.cache` location where is this directory located? Log above says `/opt/buildhome/.cache/ms-playwright/chromium-1012`, looks like right in the build root. > Furthermore node 18 support for plugins should be now available...

No strong opinion on equipment categories, since these are more about API than adhering to rules. Notes on the latest example: 1. Not having Reach in `"properties"` feels inconsistent, since...

Yeah, as above, there _are_ API convenience considerations. I think it might be best to just bite the duplication and have both derived effective reach property at root (5 or...

I disagree that improvised use is a property of a weapon. Improvised stats are set by that _rule_, so they don't differ between weapons (beyond melee/ranged which is already available...

Vehemently against discouraging closures. WP is very hook centric and sometimes complex use cases require not just _using_ an existing callback, but _manufacturing_ a very custom callback with scope on...