Andrey Savchenko

Results 76 comments of Andrey Savchenko

I don't see how inline head styles are related to preload, they are not links? They are just processed in place (and merged with critical css, depending on `mergeStylesheets` options).

That font _is_ used, detecting that is a separate problem, see #113 follow-up. The issue here is _broadly_ that critters seems to erase non-critical rules from inline blocks, which is...

Getting the same (I think) with Tailwind typography plugin: ``` 4 rules skipped due to selector errors: .prose :where(hr + *):not(:where([class~="not-prose"] *)) -> Cannot read properties of undefined (reading 'type')...

Seems like it would make a lot of sense in some circumstances. Say I have following steps: - install dependencies (success) - check code style (fail) - post cache (skip)...

@eyal0 that was not possible to override at the time I tried.

I think in Slim mechanics it would make sense to restrict the route to numeric IDs, so invalid value doesn't even match/reach controller: ```php $app->delete("/objects/{objectId:[0-9]+}", [MyController::class, 'deleteObject']); ``` See [regular...

One nuance with this block is that the way it refers to a monster isn't currently present in data or could be easily derived from it. E.g. I templated it...

> I think that makes sense and cleans up the data some. That what, precisely? :) I am not sure what's the specific desired change here.

> Melee weapons still have a range, even though they aren't ranged weapons. No, the rules do not support this. Melee weapon, without thrown property, does not have a range,...

To recap a bit, currently there are three cases in data: 1. melee weapon with `range` 2. melee thrown weapon with `range` and `throw_range` 3. ranged weapon with `range` Worth...