Peter Dave Hello
Peter Dave Hello
Cool, I'm still looking into it.
@ljharb I fixed the conflicts 😄
@ljharb to be honest, I don't think we need to test nodejs as its author will test it, on both gcc and clang, as they write the doc about compilation...
So maybe just separate the "make" part to an individual test for both gcc and clang? Then We don't need to "make" nodejs so many times per CI round.
@ljharb what's the parameters should be tested in that? If we are not passing some special cases with potential problems, I really doubt if we need to build nodejs in...
I mean in number 1 and 2, as we won't bump the nodejs version to be tested automatically, a certain build with the _same parameters_ has built successfully should always...
@ljharb I'm using `git`, `curl` and `wget` just as its installation, IMO it should be okay since that's the current way `nvm` getting `nodejs` files and install itself, and it...
No problem @ljharb , thanks for your review, I'll hope this can be done soon, the later to be merged, the higher possibility to get conflicts, do you have any...
@ljharb just asking, if it's possible to merge this earlier? Leaving this patch until v1.0.0 would only makes conflicts but no any benefits IMO, thanks.
Hello @ljharb ?