nvm
nvm copied to clipboard
nvm-sh
[New] Add `nvm self-upgrade` to upgrade nvm itself
Thanks for the PR!
This is to solve #400 - I'm not sure yet if this is the direction I want to go for self-updating. I think using curl or wget isn't ideal, because I'll want to be able to refactor the entire file structure later - but requiring git to self-update might be too restrictive.
@ljharb I'm using git, curl and wget just as its installation, IMO it should be okay since that's the current way nvm getting nodejs files and install itself, and it isn't complex for you or me to refactor in future, instead, I thought the cost is very fair enough since we can upgrade nvm very easily by this method, instead of fetch tags and checkout to new versions manually or even go to the project website and get/do the installation command again, if there is git command, we don't even need to download the whole installation script, what do you think?
Just to make sure I set expectations here: this feature is the final one I want to add before v1.0. If you're comfortable with waiting until I'm ready to add it - and if you're kind enough to check the "let maintainers make edits" box, so that I can add my own commits and do my own rebasing for you if timing doesn't permit you to have the time to do so - then I think a form of what you've contributed here absolutely can make it in! I very much appreciate your contributions and I won't make the same mistake as I did before of closing your PR in favor of my own commits, but I'm very time-driven and change-driven so being able to make my own edits will help me out :-)
In other words, I intend to primarily only rebase this for you as needed, and I'll request changes for at least 24 hours before implementing them myself, but it's still going to be a little while before I'm ready to merge this feature. Hopefully that's OK!
No problem @ljharb , thanks for your review, I'll hope this can be done soon, the later to be merged, the higher possibility to get conflicts, do you have any schedule about v1.0.0? btw, the build failed seems to be an accident actually passed the test.
@ljharb just asking, if it's possible to merge this earlier? Leaving this patch until v1.0.0 would only makes conflicts but no any benefits IMO, thanks.
It won't be merged earlier and it won't be any time soon; but this feature was never one I intended to be done by someone other than myself, and it's still a long way off.