Claudiu Popa

Results 107 comments of Claudiu Popa

Okay, I don't mind having it like that in this case. Also, we should take a look to see what other tools are doing, for instance Rubocop for Ruby and...

I think this approach sounds very good, so I'm +1 for doing it as is.

Sounds good overall. One small comment regarding `Or it could be that the config object loads the checkers and does the manipulation on itself.` This doesn't sound a good idea,...

Hey @AWhetter Let me know if there is a blocking decision to be made regarding the sub-issues for this one (I somehow forgot the state we were back then).

Do you have the benchmarks at your disposal by any chance? I am curious seeing what storing all the ASTs actually incurs. From what I recally by skimming through the...

@gwax This could be a solution, yes, but we already decided on using an `include` approach, which for me at least sounds more straightforward and easier to understand. Now the...

Wow, that's incredible, thanks for reporting an issue. I wonder if the overhead of pickling the results back to the workers is too big at this point, we'll have to...

I don't think this is intentional, it looks like a bug to me. Would you like to investigate and see what's causing this issue? It'll probably wait otherwise for a...

From these solutions, 2 and 3 sounds like the best solutions that won't introduce too much backward incompatibilities. 1 can definitely introduce bugs, since it's not expected for that node...