Micha Reiser

Results 628 comments of Micha Reiser

I would probably approach it similarly to how `bench_parser` works today. Create a `libs.txt` file with the URLs to the NPM packages. Running the parser shouldn't take a lot of...

I would put this job under a Cron job or trigger it via comment. It sounds to be an expensive job, probably we don't need it at every PR. Let's...

Would you mind adding a short outline to the PR summary how the architecture changed. You mention three threads. What's the responsibility of each thread, why are multiple threads necessary?...

Thanks for updating the description. Some feedback on the JSON format * what use cases to you see for the `duration`? In my view, this is something that scripts can...

> I think it's a valuable information, since we already have it. If the script wants the information, it would require to make another I/O operation. If we scale this...

> Thanks @magic-akari for the nice research! > > > > ## Valid cases in ambient context: > > > > 1. numerical literal > > ```ts > > class...

I'm conflicted on how to best add this to our AST so that the API encodes as many constraints as possible. * `readonly`: Modifiers is an array, which is why...

> I'm conflicted on how to best add this to our AST so that the API encodes as many constraints as possible. > > * `readonly`: Modifiers is an array,...

> > > > I prefer the third one. Could you explain why?

This new syntax is even more subtle: * Only allowed inside classes but not interfaces * Don't allow a type annotation That's why I'm currently leaning towards introducing its own...