tools icon indicating copy to clipboard operation
tools copied to clipboard

📎 Most popular NPM Libs CI test

Open MichaReiser opened this issue 3 years ago • 5 comments
trafficstars

Description

Create a CI test that runs the parser against the 1000 most popular npm packages and fails if any of them fails parsing.

Plus points for:

  • CI job only runs on lexer/parser changes
  • It's possible to run the command locally too

MichaReiser avatar Feb 10 '22 09:02 MichaReiser

How do you plan to do that? Personally, I don't - think it's doable doing this against all these repos. Unless we have bare package resolution, trying to get the source code from repo/npm tarball is going to require lot of resources

ematipico avatar Feb 10 '22 09:02 ematipico

I would probably approach it similarly to how bench_parser works today. Create a libs.txt file with the URLs to the NPM packages.

Running the parser shouldn't take a lot of time in release mode. Even parsing TypeScript takes only 250ms on my machine.

MichaReiser avatar Feb 10 '22 09:02 MichaReiser

Fair point! Sounds good!

I would put this job under a Cron job or trigger it via comment. It sounds to be an expensive job, probably we don't need it at every PR.

ematipico avatar Feb 10 '22 09:02 ematipico

I would put this job under a Cron job or trigger it via comment. It sounds to be an expensive job, probably we don't need it at every PR.

Let's see what the runtime is. We could even consider putting t into the conformance job because the most expensive part will be compiling the release binaries.

MichaReiser avatar Feb 10 '22 09:02 MichaReiser

👋 @rome/staff please triage this issue by adding one of the following labels: S-Bug: confirmed, S-Planned , S-Wishlist or umbrella

github-actions[bot] avatar Nov 23 '22 12:11 github-actions[bot]