Mesabloo
Mesabloo
Let's merge this, but we know that currently, Windows support for wcwidth (at least the officially published package) is a bit lacking. Would you mind commenting out `windows-latest` in the...
There's a lot to unpack here. Let's check bit by bit. I'll comment directly here and there (and maybe request some chnages) while reviewing the code.
Overall, this should be almost ready to merge. The code is however quite "blocky", as in there are big chunks of code with no empty lines. I personally find it...
Hello @ruifengx, it's been quite a while. Do you have any update on this, any work left in commits not pushed?
Hey no worries! I'm also quite busy (hence the fact that I'm popping a message here only now) so it'll take a bit of time to continue reviewing the code...
Thanks for the issue. I do not quite understand the point of restricting the version range downwards. For example, all the code works great with say `text` v1. While this...
Thanks for the issue! From the issue you opened in https://github.com/solidsnack/wcwidth/issues/7, this is a problem that we already faced in https://github.com/Mesabloo/diagnose/issues/11#issuecomment-1234077695. The version of `wcwidth` which is on Hackage (0.0.2)...
As long as the width of the space character is patched, then yes this should be the thing to do to make it work. The bounds on `wcwidth` should already...
See this comment: https://github.com/Mesabloo/diagnose/pull/13#issuecomment-1277784256
From what I see over at https://docs.gradle.org/current/userguide/compatibility.html#java (more specifically table 1), it seems that you cannot run Gradle 6.7.1 with Java 18 (you need Gradle 7.5+, or Java 15-). If...