diagnose

diagnose copied to clipboard

One of our Windows users is reporting problems due to the dependency on wcwidth. I have reported the problem upstream: https://github.com/solidsnack/wcwidth/issues/7

I am currently investigating a solution to the problem

Thanks for the issue!

From the issue you opened in https://github.com/solidsnack/wcwidth/issues/7, this is a problem that we already faced in https://github.com/Mesabloo/diagnose/issues/11#issuecomment-1234077695. The version of wcwidth which is on Hackage (0.0.2) unfortunately does not bundle the pure Haskell implementation (see https://github.com/solidsnack/wcwidth/pull/3 which came after the release of the version 0.0.2). Unfortunately, there is nothing I can do to fix this, other than just copy the source of the package inside this one (which I'd rather not, ideally). The pure Haskell implementation has been rewritten in https://github.com/solidsnack/wcwidth/pull/6 but we also found a bug in https://github.com/Mesabloo/diagnose/issues/11#issuecomment-1236313862 where a single space character does not have the correct width (0 instead of 1). This was meant to be fixed but I don't think it was yet.

Thanks for the quick reply (and the great library). I didn't think about looking into the other issue. But apparently the solution is for upstream wcwidth to release a new version to Hackage, and to then adjust the lower bounds in diagnose accordingly. Right?

As long as the width of the space character is patched, then yes this should be the thing to do to make it work. The bounds on wcwidth should already be relaxed enough to account for any update which does not go beyond 1.0.0, but we'll see if it needs an update.

Does it mean that diagnose does not work on windows currently?

See this comment: https://github.com/Mesabloo/diagnose/pull/13#issuecomment-1277784256