Luca Palmieri

Results 278 comments of Luca Palmieri

It'll be out of date for a bit, but we're going to update it to the latest version shortly after it comes out 👍🏻

Thanks for the ping @tobz! The workshop has been updated to the latest version of `metrics`.

I think linking to the repository's homepage would be better, otherwise it's unclear how to actually progress through the workshop/what needs to be installed/etc.

Left a bunch of comments - sorry for the long delay! Another issue that needs to be addressed: `rustqlite` offers a sync API, while we are running in an async...

That would work for the Redis case, yes. I'd suggest returning a `secrecy::Secret` though.

No, it should be added to the `Session` struct, as @robjtede suggested. I was just mentioning that achieving the same objective (limiting the number of concurrent sessions) with other backends...

I can definitely review the PR 😁 Yes, I'm suggesting we pull in the `secrecy` crate for this change. The session key is highly sensitive key material and it should...

It's easier for me to provide feedback if you open a draft PR 👍🏻

(I'm a bit busy at the moment, I'll try to get to it before the end of the Christmas holidays, but no promises)

A question first: why is this an issue? Are you trying to do something where this becomes a problem or is it more of a curiosity/optimisation/why not question?