Luca Palmieri

Results 278 comments of Luca Palmieri

If you can provide steps for me to reproduce I can try to have a look @treamology.

A fix has been released in 0.1.56 thanks to @Kobzol's work 🎉 Can you confirm it works as expected @seanpianka?

Doesn't our current extension span both the response and the request?

Wouldn't it be simpler to have a single method on the trait that takes a `Result` instead of two separate methods?

I don't think we need combinators, you can fallback on the default functionality for errors (or successes) using: ```rust pub trait RetryableStrategy { fn handle(&self, outcome: Result) -> Option; }...

We can discuss merging once the issues I raised are addressed @AxelGreen 👍🏻 @tl-rodrigo-gryzinski: thinking about it again, considering that `RetryableStrategy` is storing function pointers we do get that initialisation...

If there is consensus on the possibility of returning successes from the `Err` variant, I am happy to change the PR and simply cast both variants to `Response` without further...

Updated the PR to avoid `panic` on the `Err` variant if it returns a success.