Matthew Davidson comments

Results 220 comments of


                                            Matthew Davidson

[client] Don't close connections when HttpObjectAggregator is on the pipeline

Side note: I find the word "complect/decomplect" kind of silly. Plenty of better-known alternatives already exist: intertwined, mingled, mixed, entangled, enmeshed, etc. Likewise for the undoing process: disentangle, separate, untangle,...

clj-kondo config

Thanks, this is on our to-do list. Of course, PRs welcome, too 😄

BlockingQueueSource should be closable

~~Unless overridden, the default impl of `.close` does nothing, and it's not currently overridden for `BlockingQueueSource`. I agree the "source-wrapped" version should be closable, though, and prevent further takes.~~ EDIT...

manifold.deferred/timeout! does not unwrap the target deferred

@alexander-yakushev This doesn't have anything to do with `timeout!`. If you remove the `timeout!` call from the `let`, it still exhibits the same behavior: ```clojure (let [d (md/deferred)] (-> d...

Compatibility with graal native-image

@willcohen Do you have a test case and a Clojure version for this error?

Mapcat cannot handle mapping functions that return streams?

I'm torn on whether to treat this as a bug or not. On the one hand, the docstring for core `mapcat` says "function f should return a collection", while the...

Fix issue with listeners not being cleaned up in alt'

@solatis I've been diving into the code to try and understand your suggested PR. I think there's a bug: the original code used `chain'`, which internally calls `unwrap'`. This will...

Fix issue with listeners not being cleaned up in alt'

@ztellman Does this analysis make sense to you?

Fix issue with listeners not being cleaned up in alt'

Not a problem. I'm still here. One correction to my comment above about `chain'`: I think you definitely to need to keep the `(chain' x)` that's present in the original...

Fix issue with listeners not being cleaned up in alt'

@solatis Any time to work on this?