Matthew Davidson

Results 220 comments of Matthew Davidson

Thanks for submitting this. I think I would prefer to fix Dirigiste, if possible. PRs can be submitted at https://github.com/clj-commons/dirigiste At a first glance, why isn't this being garbage-collected? Are...

@Yneth Can you share a minimal test case reproducing it?

@Yneth Even if you don't have a test case, did you save the profiling session? It would be nice to take a look at it.

> @KingMob I guess giving a possibility to specify the whole pool would be nice, but it would require making `(create-connection` function public. Not sure if it is ok to...

@Yneth Any updates? After doing some work with Dirigiste recently, I want your PR. 😄

@arnaudgeiser Your test case, that crawls a lot of domains, reminds me a _lot_ of: 1. https://github.com/clj-commons/aleph/issues/394#issuecomment-404400781 in #394 2. https://github.com/clj-commons/aleph/issues/461#issuecomment-453145969 in #461 As for the objects not being cleaned...

OK, I misread a couple things. Your code is recurring with another 10000 domains. In my tests, this works out to ~770k per domain. Still highish, but there's 5 major...

Just forced it to make 3 conns per domain, and all I got was endless utilization values of 4. I need to set this aside for now. Even if it's...

Yeah, there's some weird stuff going on, with few tests, and a lot of that is why I'm not a fan of Dirigiste. Based on a sampling period of 10ms,...

Keep in mind, this is still low priority to my way of thinking. The Dirigiste pooling problem only applies to outgoing client connections, where talking to zillions of different servers...