Jente Sondervorst
Jente Sondervorst
Hi, thanks for the patience here. Finally we where able to get the dump from our worker nodes. We've extracted a zstd file from our openshift cluster. Then we decompressed...
@shanman190, - you would then have to call both these recipes from everywhere you want to bump a dependency? Or would you still call it from the `ChangeDependency`? Are we...
I have pushed a draft PR that addresses this one. The implementation is still quite dirty, but I feel this Trait could easily be added to other recipes like UpgradeDependencyVersion...
Sure! Nothing here is mine 😉 If you need assistance, feel free to reach out!
- We have https://github.com/openrewrite/rewrite/pull/5492 to address this one. @timtebeek can you give that one another review so we can close this whenever you have some time?
[This line](https://github.com/openrewrite/rewrite/blob/main/rewrite-java/src/main/java/org/openrewrite/java/tree/JRightPadded.java#L156) gets reached which makes the string notation not have an after space. reaches through: --> DependencyUseStringNotation:visitMethodInvocation:116 --> J$MethodInvocation:withArguments:4034 --> JContainer:withElements:171 --> JRightPadded:withElements:156 I do not think we can...
@shanman190 @knutwannheden @timtebeek I've created a fix for this particular recipe that could work for other use cases also (leaving the responsability of calculating that last space to each recipe...
I think this is awesome! If possible, we could enhance it with the versions if the version itself is declared higher up / somewhere else in the cursor. But if...
@knutwannheden You mentioned you had other idea to test this?