Jente Sondervorst

Results 39 comments of Jente Sondervorst

Here only the addition to one of the 2 datatables is happening: this line https://github.com/openrewrite/rewrite-spring/blob/0af9942357688f00147743762dcdf9680bf34bab/src/main/java/org/openrewrite/java/spring/search/FindSpringComponents.java#L77 Should be sufficient to add ```java springComponents.insertRow(ctx, new SpringComponents.Row(getCursor().firstEnclosingOrThrow(SourceFile.class).getSourcePath().toString(), TypeUtils.asFullyQualified(requireNonNull(m.getReturnTypeExpression()).getType()))); ``` We can provide PR...

I can confirm this is also showing in the `MergeYaml` recipe -> was able to bypass the error by using `$.`. Strangely enough, when I run the tests that execute...

While I agree we do not have consistency in these recipes on when to impact a property and when not to, we need to think of the edge cases during...

Well spotted (I take it you found out the hard way with #5036) Will try to add this ignore check + get it documented. A comment would indeed become very...

I had worked locally on supporting comments, but it's really a pain with the prefixes containing all the comments. Perhaps a remove comments boolean input and then: - if true,...

As I am on a 3 weeks leave, responses will be a bit late. Feel free to take this further with anyone else if I fail to answer in a...

Locally this test is green, but here OOM. 🤔

This failing test is the only test that is using the static `fromRuntimeClasspath` method. This method scans entire RuntimeClassPath (250Mb). Together with the GradleParser (classpath taking 200Mb) and the GroovyParser...

@leochr, Thanks a lot for the quick answer. Raised our question over there also. At this moment testing an e2e pipeline every 30 minutes with `23.0.0.4-full-java17-openj9-ubi`, in which we did...