Icelk

Results 105 comments of Icelk

It is standard behaviour for the path to default to `/`. This is because you're trying to access the root, often being the folder `/`, which often gets translated to...

I also agree. Should I make a PR fixing the parsing issue?

I propose we change this and release a 0.2.4 version, stating the changes clearly in the changelog. This bug should not be part of the most popular HTTP type library....

Me too. Looking back at the release history, this should be a minor release. But what does this change? - 1 byte in debug implementation - returning `None` instead of...

Any new updates on this? I think adding a method on `Uri` to get the fragment would be helpful, and maybe docs regarding some aspects of this issue? I'd be...

Should removing `\` be completely removed? It also happens here: `\[\[`, when you want to have `[[` in the document without ruining syntax highlighting.

I can confirm this works as expected. I disabled the handshake feature and handled that myself.

The CI is failing because I added `tungstenite` as a path dependency for development. Should I add it as a git reference, so the CI succeeds?

Precisely. It feels wrong to include unused code, especially whole dependencies. Increases compile time and attack vectors. But I do understand if you'd prefer not to add additional `#[cfg()]` attribute....

Nice! Then I'll send a PR to this repo and to tokio-tungstenite this weekend. Thanks!