tokio-tungstenite

tokio-tungstenite copied to clipboard

This is the PR I promised in snapview/tungstenite-rs#296. It requires snapview/tungstenite-rs#300 to be merged and released before we can release this.

This adds a cargo feature named handshake which is enabled by default. Disabling it removes the handshake feature of tungstenite.

I can confirm this works as expected. I disabled the handshake feature and handled that myself.

The CI is failing because I added tungstenite as a path dependency for development. Should I add it as a git reference, so the CI succeeds?

Thanks for the changes! It's ok, let's wait until we merge the tungstenite and release it, so that we can merge this one and release it as well.

Great! Thanks!

Just a reminder: should the docs in README be updated?

Possibly. We did not document the connect feature though. But perhaps it makes sense to document both connect and handshake.