Eldred Habert
Eldred Habert
"Garbage" label creation is fairly widespread (`jr` targets next to data blocks do the same), but needs to be handled somehow, the target cannot be simply omitted, as the instruction...
See gbdev/rgbds#483.
I think the functionality present as-is is good enough, and is worth merging after rebasing. Sure, it may be improvable, but such additions can always be merged in a second...
Wouldn't it be better to split that into several flags? For example, one could want fallthrough comments but keep the rest
I'd be for `--style` instead of `--theme`. Makes more sense for a coding style. What would the individual flags be, though? Here's an idea: `--style param=value` (such as `--style fallthrough=yes`)...
> The --style param=name idea sounds good, as long its possible to coerce argparse (or something else?) - to support that style of argument. If it can't parse that itself,...
> The former would specifically be all --styles overriding all --presets wouldn't it? Yep, whereas the first would have any `--style` to the left of a `--preset` would be overridden.
No matter how it's implemented, the gist of it was that I'd rather see all `--style` override all `--preset` no matter the position. :P
Shouldn't the code be updated to make use of some of the new constants?
This seems like a related bug: after waking my PC from suspend for a while, the MPD module fails to update despite the rest of waybar updating properly. Clicking the...