Huidae Cho

Results 158 comments of Huidae Cho

By default, a `G_OPT_V_FIELD` option gets assigned 1, but @mwlake might have wanted to explicitly require it by clearing it out, but `input_id->answer = NULL;` should be the right way,...

> @HuidaeCho pls assign this PR to the `grass8` branch @neteler I think you meant rebasing to grass8? Or adding a new milestone for grass8?

> moving everything to the top level `src` looks clean, but moving everything to the top level is more consistent with the core. But still, addon doesn't separate scripts from...

TODO: This module needs `indent` after this PR is merged.

@neteler Please test it with negative, non-positive, negative to positive, and 0 to positive rasters. It shouldn't affect positive rasters, but just in case test them too. It still doesn't...

> * the maximum shown is not that reported thru stats (see below, but I didn't manage to reproduce it!): @neteler I couldn't reproduce it. Can you share your data...

> draw.c:273:40: warning: ‘%d’ directive writing between 1 and 11 bytes into a region of size 4 [-Wformat-overflow=] > 273 | sprintf(DispFormat, "%%%dd", (int)(log10(fabs(maxCat))) + 1); > | ^~ >...

Let me summarize what this PR does: * For a positive raster, everything is good. Output should be exactly the same as without this PR. * For a 0-to-positive or...

> > > @neteler Please test it with negative, non-positive, negative to positive, and 0 to positive rasters. It shouldn't affect positive rasters, but just in case test them too....

Now, fatal error on a non-positive raster and warnings on min