grass-addons icon indicating copy to clipboard operation
grass-addons copied to clipboard

g.projpicker: Import projpicker from the soon-to-be core module

Open HuidaeCho opened this issue 4 years ago • 4 comments

Merge after https://github.com/OSGeo/grass/pull/1891

HuidaeCho avatar Aug 02 '21 19:08 HuidaeCho

@HuidaeCho pls assign this PR to the grass8 branch

neteler avatar Dec 11 '21 11:12 neteler

@HuidaeCho pls assign this PR to the grass8 branch

@neteler I think you meant rebasing to grass8? Or adding a new milestone for grass8?

HuidaeCho avatar Dec 13 '21 16:12 HuidaeCho

At time is is submitted to addons base branch grass7 (see above). I assume it should be changed to grass8, e.g. by using the "Edit" button in the Web interface next to the title.

neteler avatar Dec 13 '21 17:12 neteler

I think there is also some confusion about what base is being changed. The branch "against" which the PR is made is called base in GitHub interface (see the Edit button for a PR). However, we have also operation rebase (in Git and potentially also in GitHub PR interface when merging) which re-creates all commits from a branch on top of another commit (typically same base branch, just later commit). These two share a lot in common, so perhaps that's the reason for the same name, but who knows, GitHub does have an unfortunate way of naming things IMHO (namely, a pull request on GitHub is a merge request on GitLab).

wenzeslaus avatar Dec 14 '21 03:12 wenzeslaus