Guillaume Dupuy

Results 9 comments of Guillaume Dupuy

Hey ! Regarding compiling this, it's a Qt project so you can either : - Open it with QtCreator and compile from here - Compile it from CLI with the...

You are correct about Scriptcraft beeing server-side only. > but I wonder how hard it is to only learn enough Java to add my custom blocks in a different package...

It's because the craftItemEvent has no player parameter (see : https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/CraftItemEvent.html). You probably want to get the inventory of the craftItemEvent and then call getHolder() on it to get who...

Is this supposed to work ? Trying the following simple code ``` var https = require('https'); https.require('https://google.fr'); ``` Gives me the following error : ``` [23:35:57 WARN]: [scriptcraft] Plugin scriptcraft...

This needs to be done in the Java wrapper who logs all the exception : https://github.com/walterhiggins/ScriptCraft/blob/master/src/main/java/bukkit/org/scriptcraftjs/bukkit/ScriptCraftPlugin.java#L78 But I don't think it's a wise idea to remove error logging, sometimes it's...

Some links to read about the transition : https://www.spigotmc.org/threads/minecraft-1-13-what-to-expect.288714/ https://www.spigotmc.org/threads/bukkit-craftbukkit-spigot-bungeecord-1-13-pre7-development-builds.328883/

I'm just removing a couple of trailing whitespaces (because usually there is none in the file), i'm not changing the whole indentation scheme of the document :)

stone (actually it's slab.stone) is already defined line 98 : https://github.com/walterhiggins/ScriptCraft/blob/development/src/main/js/modules/blocks.js#L98 and fence is actually overwritten by the fence object on line 323 : https://github.com/walterhiggins/ScriptCraft/blob/development/src/main/js/modules/blocks.js#L323 so it was never used...