fusionauth-netcore-client

fusionauth-netcore-client copied to clipboard

exposing client builder to allow httpClient.

1

DefaultRestClient.cs is the change that will stick. The changes to FusionAuthClient.cs and FusionAuthSyncClient.cs will have to be added to [fusionauth-client-bulder](https://github.com/FusionAuth/fusionauth-client-builder). I will add that now.

mark-robustelli

When run alone it works fine. When run with collection of tests, fails randomly. I think this has to do with the fact that test are run async and this...

mark-robustelli

mark-robustelli

updating Newtonsoft package

mark-robustelli

Performance Optimization

2

In .net core, HttpClient is meant to be a singleton with the same lifecycle as an endpoint. This is the canonical guide for the issues this causes, but it is...

lukevp

Remove dep on NewtonSoft JSON and use System.Text.Json instead

7

### Description See this comment https://github.com/FusionAuth/fusionauth-netcore-client/issues/13#issuecomment-608204114 Thanks to @ukevp for this suggestion: > Another standardization thing you might consider is your current use of newtonsoft.json. The history of that library...

robotdan

DeactivateUsersByIdsAsync should default to using a POST body

1

When calling `client.DeactivateUsersByIdsAsync`, FusionAuth will default to sending this request using queryParams as in ``` DELETE /api/user/bulk?userId={userId}&userId={userId}&userId={userId}&userId={userId}&userId={userId}&userId={userId}&userId={userId}&userId={userId} ``` It should default to sending this request using a POST body as...

jobannon

GenerateEmailVerificationIdAsync Does not generate an Email VerificationId and does not correspond to Documentation

1

/// /// Generate a new Email Verification Id to be used with the Verify Email API. This API will not attempt to send an /// email to the User. This...

YingMorris

Why fields instead of properties?

3

This issue partially relates to #21: "It's very clear you guys are Java developers. Lowercase properties, reverse-domain namespaces. To a .Net developer, this feels really gross to work with." Recommendation:...

adambajguz

Need to test and update the value to include later version of .NET core. https://docs.microsoft.com/en-us/dotnet/standard/frameworks

mooreds