fusionauth-netcore-client icon indicating copy to clipboard operation
fusionauth-netcore-client copied to clipboard

Why fields instead of properties?

Open adambajguz opened this issue 4 years ago • 3 comments

This issue partially relates to #21: "It's very clear you guys are Java developers. Lowercase properties, reverse-domain namespaces. To a .Net developer, this feels really gross to work with."

Recommendation:

  • Models and API Client should use properties for public members

adambajguz avatar May 15 '21 20:05 adambajguz

Thanks for your feedback. We're currently reviewing how we generate our client libraries in order to offer a more native experience, but it's good to hear specifics. Thanks!

mooreds avatar May 17 '21 12:05 mooreds

I just checked out the source code and thought "oh wow this is ugly. Looks like a Java dev trying out C# for the first time". But as long as it works then good job. I just wish I didn't have to include code calling and using this Java-styled API in my workplace's codebase because it's mixing up 2 very different code styles in the same project/s. It might confuse the other devs.

Mike-Logit avatar Aug 09 '22 20:08 Mike-Logit

Have you all reviewed the Open API specification? We are likely going to be moving to Open API here soon, so take a look there and let us know what you think:

https://github.com/fusionauth/fusionauth-openapi

voidmain avatar Sep 15 '22 16:09 voidmain