Maurycy Zarzycki

Results 15 comments of Maurycy Zarzycki

If the idea is to know in a child widget whether it still is used, can't you just check its dom nodes to see if their root node? And if...

> `check its dom nodes to see if their root node` what does this mean? If unmounted, its parent will be the document? If you call `getRootNode()` on an elements...

@hoelzro I am also planning to drop ~~a sick album~~ an update which includes identical tests but written in Playwright, gonna have it ready in an hour or so.

~~#6796~~ (edit: #6735) I'd love to have this one since it's something that's actively annoying me :)

@Jermolene Whoops, apparently I either can't copy or use Github interface. I meant to link to #6735, sorry!

Here is a review of the changes I've pushed: * I've removed the three `handleKeydownEvent` methods. Now there is only one and it accepts an optional second argument. * From...

@pmario Thanks, updated! ---- Edit: The below section was moved to the body of the PR. ## Test Tiddlers: ``` title: Shortcut tags: $:/tags/KeyboardShortcut key: ctrl+l Priority = {{!!priority}} ```...

I'll tackle updating the documentation for global shortcut later today.

@saqimtiaz I was pretty sure it already worked with `simple` editor. I'll check both with it and `codemirror`!

I'll check the test cases I've added to the PR description after putting the kid to sleep, and if everything works I'll move it from draft to real PR