EQUENOS

Results 22 comments of EQUENOS

> could `qualified_name` be a property that uses the parent to determine the name? Yeah but there're no scenarios where subcommands move to another parent. Renames are not supported either...

> Perhaps a `parents` field I don't think it's needed because we have `root_command`. The only use case of `parents` is to get all parents of a subcommand (with assistance...

> Also another issue with the slash command copy - the `parent` still points to the old instance Ah, right, I forgot to test copies... I will fix that.

> `InvokableSlashCommand` should have a parent attribute too, but this can be None. It's there, I added it after the first review

> Since the body is now copied too, does this affect this part of the code for slash commands? It shouldn't affect it, however, I think I will change `copy(body)`...

> that's a side effect of how x_attrs is implemented and can likely only be fixed as part of a general refactor I can do that in a separate PR

Implementing this would definitely be an interesting experience! I suspect that we can't do anything better than just indexing the commands of one type by `(name, set_of_guild_ids)`. This will certainly...

The last attempt to save this PR is to concatenate all custom_ids of view components with the interaction ID before sending the view as an interaction response. While this is...

I think it's better to catch critical errors instead of crashing the client, because if some developers encounter a regularly appearing critical error they won't be able to ignore it...

Thank you for reporting this, it's now fixed