Results 150 comments of Stijn de Witt

Sorry for the long rant :) but I still have something to add. For me the rule should be this: `Making your password longer, makes it stronger` The current behavior...

The idea of JSDoc is kinda to allow tooling to use it right? E.g. http://usejsdoc.org/about-getting-started.html#generating-a-website I think it should be in a subfolder because the auto-generated docs are really reference-guide...

If you decide to try your hands on this, let me know. Otherwise I will probably pick this up somewhere in the coming weeks.

What I noticed is that the polling loop just loops over the elements that have resize events attached in the order they were attached in (or at least in the...

Lol. I am pretty new to GitHub and was not really using it when I wrote above post. That is also the reason I did not reply to you for...

Yeah I know. But my code is not in GitHub. So it will take some effort on my part to create a pull request. So I'd first like to hear...

I do see an example: https://github.com/ChainSafe/discv5#example ```js import { Discv5Discovery, ENR } from "@chainsafe/discv5"; import Libp2p from "libp2p"; import PeerId from "peer-id"; const myPeerId: PeerId = ...; const bootstrapEnrs: ENR[]...

Found this [specification](https://github.com/defunctzombie/package-browser-field-spec) for the `browser` field, which suggests it is indeed wrong.

According to the spec above, the browser field is either: * A string with the path to the alternative file to use for `main` (so ES5), or * An object...

Yes, probably. And the part in the README about it. Then of course the question remains, how do we deal with differences between Node and Browsers in a library. So...