Dimitar Krastev
Dimitar Krastev
@seladb can you look through this one when you have time? It has been sitting for a while.
@tigercosmos I split the PR into chunks. #1971 is a part of it. After that is merged, we can review / merge this one as it will be smaller.
Closed in favor of #2026
@adityaxa I think we already have an open PR for a lot of the make_unique cases #1854. You are welcome to open a PR with one of the other items...
@seladb @tigercosmos @clementperon @egecetin Can I get some first impressions on the idea of this draft?
> @Dimi1010 is it worth it to rewrite `BgpLayer`? 🤔 Dunno yet. I have been mostly using it as a test bed for expanding the idea I had in the...
> @Dimi1010 Is it possible to split this PR? It seems the PR is too large to review. Possibly, but this is still a WIP.
Might work on this later. Closing this for now so it doesn't clutter.
@bhaskarbhar No worries about the flaws. That is why the reviews are for. Ty for the effort. :)
> @Dimi1010 did you have a chance to run the DPDK test locally? Unfortunately, the CI doesn't run them because setting up DPDK in CI is not easy, so we...