Dimitar Krastev

Results 109 comments of Dimitar Krastev

@seladb Added automatic generation of the transition headers. I think that will be good enough? Only the install interface considers these files as in the "include" directory. The build interface...

@seladb Scrapped the transition headers idea due to having the critical issue of polluting the global include on install. I think just keeping the `$` in addition to the new...

@seladb Got a bit of a question for desired implementation of backwards compat. It should be possible to have both the old and new install #include format if we essentially...

The question is more: "Do we want the flag to be there to allow people to disable the old includes, or do we want them to be always on until...

@seladb @clementperon Added the flag `PCAPPP_ENABLE_OLD_STYLE_INCLUDE` (default `ON`) to both the root `CMakeLists.txt` and `PcapPlusPlusConfig.cmake`. It will also print a deprecation warning if it is turned to `ON`. Also can...

Hi @JasMetzger , Not really that familiar with XDP, but from what I understand the AF_XDP concept is based on 4 queue types: - **FillRing:** Used for transfer of memory...

> On the creation of the socket function one specifies a queue id (third argument). My understanding is that a NIC provides 4 or so queues that can be used...

> I was afraid you would ask that. OK---I'll give it a go. I suppose I am forking from the master branch? I have NIC with multiple RX queues I...

Changing base branch to `dev` as per `Contributing.md`.

Can we review this? It has been sitting here for a while.