Daniel Stout

I tried changing the benchmark like so: ``` return () => { var engine = new RazorEngine(); var template = engine.Compile(content); return () => template.Run(context); }; ``` Which compiles the...

> First of all lets classify engines. they are either compile or evaluate document, then, they either do internal caching or not. All the engines in this benchmark appear to...

Are you certain that's how RazorLight works? I took a quick look and in the Build method of RazorLightEngineBuilder, it creates a new EngineHandler (https://github.com/toddams/RazorLight/blob/22381db30ca3c61b4b1e4004e1536407dd138e49/src/RazorLight/RazorLightEngineBuilder.cs) which has its own cache....

What about this? In RazorEngineCore you do: ``` string fileName = string.IsNullOrWhiteSpace(options.TemplateFilename) ? Path.GetRandomFileName() : options.TemplateFilename; RazorSourceDocument document = RazorSourceDocument.Create(templateSource, fileName); ``` I.e. it's creating a file in the filesystem...

Wow, not sure where you got the vibe that I'm arguing! I'm just trying to understand the results of the benchmark and to help you improve this library. No hostility...

I don't think an informal benchmark like that is an accurate representation of performance - like you say, when you set it up like that, the order of execution matters...

Ah, okay, thanks for the reply - that's what I had implemented as a workaround but I assume rendering the image out to a buffer just to read it back...

`deploymentMethod: direct` worked great! Our average deploy time went from 9-10 mins to 3 mins.

It looks like this is caused by this line in `serverless-aws-alias-fixed`: ``` const monitorStack = require( Path.join(this._serverless.config.serverlessPath, 'plugins', 'aws', 'lib', 'monitorStack') ); ``` In the recent versions of Serverless, it's...

My opinion would be that it'd be better to add it to MapSpaYarp, since it seems to me that ideally SpaDevelopmentServerOptions could stay in sync with the "real" version that's...