Dustin L. Howett

Results 663 comments of Dustin L. Howett

This test failure on ARM64 is _durable_ (it keeps failing) and _nonsensical._ https://github.com/microsoft/terminal/blob/d3a18b904123b95a7b5a1ea2307f064cf3e28c94/src/buffer/out/ut_textbuffer/TextAttributeTests.cpp#L116-L127 Line 127 is failing, because `GetColor` is returning `#0C0C0C` instead of `#00FF00`. We just constructed the attribute...

_Also it only fails in release._ Figures.

I am starting to suspect an ARM64 code generation issue. ![image](https://github.com/microsoft/terminal/assets/189190/fc6f6a79-9822-4034-804e-927c9bae8633) `attr.GetBackground().GetColor(...)` optimizes down into a direct load of index 0 from the color table. This is after the entire...

Here's a less red-yarn-and-thumbtacks image of the comparison and data flow

> we can't merge till the compiler bug is fixed The compiler bug reproduces in complete isolation, without TAEF. I don't think this PR caused it, it only found it.

If this arm64 build passes, I will reupdate and ingest taef 10.92

The compiler bug _may_ only be fixed by VS 17.11 (!)

Banished back to draft status

It's still broken! AHHAHAHA