terminal

terminal copied to clipboard

I'm running this PR through the PGO build as well -- i will merge when it is done. @lhecker @zadjii-msft I need a re-review on the last push

Feb 12 '24 18:02 DHowett

This test failure on ARM64 is durable (it keeps failing) and nonsensical.

https://github.com/microsoft/terminal/blob/d3a18b904123b95a7b5a1ea2307f064cf3e28c94/src/buffer/out/ut_textbuffer/TextAttributeTests.cpp#L116-L127

Line 127 is failing, because GetColor is returning #0C0C0C instead of #00FF00. We just constructed the attribute with green as the background index above.

I need to look at this on an actual ARM64 device...

Feb 12 '24 19:02 DHowett

Also it only fails in release.

Figures.

Feb 12 '24 19:02 DHowett

I am starting to suspect an ARM64 code generation issue.

attr.GetBackground().GetColor(...) optimizes down into a direct load of index 0 from the color table.

This is after the entire attribute is const-initialized to for sure be IsRGB.

Feb 12 '24 20:02 DHowett

Here's a less red-yarn-and-thumbtacks image of the comparison and data flow

Feb 12 '24 20:02 DHowett

Did we ever file an internal issue on the ARM codegen thing here?

Feb 22 '24 12:02 zadjii-msft

I believe it's this one: https://developercommunity.visualstudio.com/t/Bad-ARM64-codegen--maybe-during-constant/10583372

Feb 22 '24 12:02 lhecker

got it, so that's https://task.ms/dd/1969044 internally. For the sake of triaging the PR backlog, I'm gonna move this to a draft (since we can't merge till the compiler bug is fixed)

Feb 22 '24 14:02 zadjii-msft

we can't merge till the compiler bug is fixed

The compiler bug reproduces in complete isolation, without TAEF. I don't think this PR caused it, it only found it.

Feb 22 '24 16:02 DHowett

If this arm64 build passes, I will reupdate and ingest taef 10.92

Apr 29 '24 17:04 DHowett

The compiler bug may only be fixed by VS 17.11 (!)

Apr 29 '24 17:04 DHowett

Banished back to draft status

Apr 29 '24 17:04 DHowett

It's still broken! AHHAHAHA

Jun 24 '24 21:06 DHowett

/azp run

Jul 22 '24 19:07 DHowett

Pull request contains merge conflicts.

Jul 22 '24 19:07 azure-pipelines[bot]

/azp run

Aug 14 '24 20:08 DHowett